Conversation
|
|
||
| ### Required Packages: | ||
| pip install nltk requests vaderSentiment | ||
| pip install matplotlib scikit-learn scip |
There was a problem hiding this comment.
This is really minor, but these two lines came out as on the same line which made it initially difficult to understand that there were two commands. Make sure that your markdown styling is what you want it to be in the final product.
| for text in all_texts: | ||
| wordlist = text.split() | ||
| for word in wordlist: | ||
| if(word not in allwords): |
Elepert
left a comment
Elepert
left a comment
There was a problem hiding this comment.
Overall, really good work. Each function has an informative docstring. Code is concise and clean.
|
Re: "I found unit testing quite challenging for the data sets of this size and nature": one technique is to use a small test set for unit tests. For example, in GeneFinder, tiny sequences are used in the unit tests, in order to make them manageable and debuggable. (In GeneFinder, I would actually use smaller unit tests, as in the GeneFinder solution set.) |
|
There's substantial duplication between |
3 participants
No description provided.